Skip to content

Mhirsch-wip #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Mhirsch-wip #32

wants to merge 14 commits into from

Conversation

michellehirsch
Copy link
Member

README.md Updates for ease of use, new features, and slight changes to recommendations.

Ease of use:

  • Summary of recommended folder structure near top of document.
  • Link to exemplar repos at bottom of document

New features:

  • Updated discussion of Toolbox Packaging to include Project-based workflow introduced in R2025a, in addition to Toolbox Packaging Tool-based workflow for prior releases.

Updates to recommendations:

  • Use private folder instead of internal, since naming a folder internal doesn't communicate to end user that code should not be called.
  • Updated gettingStarted.mlx to GettingStarted.mlx, for consistency with MathWorks naming standards for examples.

…oot Folder section

First pass of updates:
* updated gettingStarted.mlx to GettingStarted.mlx to math standard that example files use Upper Camelcase Names
* Renamed Root Folder to Root Folder Name and Contents to set a clearer expectation of what would be included.
Starting to work on updates for 25a toolbox packaging workflow.
@rpurser47
Copy link
Member

rpurser47 commented Jun 19, 2025

@michellehirsch Per our in-person conversation:

  1. Move the TL;DR work into a separate branch and remove from Mhirsch-wip #32.
  2. Agree that we should move toolbox/gettingStarted.mlx to toolbox/doc/GettingStarted.mlx. Note that we'll have to update the buildfile.txt in arithmetic to remove the workaround that handles it.
  3. Adopt solution proposed in "internal" folder doesn't achieve it's desired objectives #31

@rpurser47
Copy link
Member

rpurser47 commented Jun 19, 2025

@rpurser47 and @bpancras to review the proposed R2025a project based toolbox packaging workflow recommendation.

@michellehirsch
Copy link
Member Author

Addressed Rob's feedback.

@michellehirsch michellehirsch requested a review from rpurser47 June 19, 2025 20:08
Copy link
Member Author

@michellehirsch michellehirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of intro to use doc/GettingStarted.mlx looks good

Copy link
Member Author

@michellehirsch michellehirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made all requested changes. Ready for @rpurser47 to review again.

@michellehirsch michellehirsch requested a review from rpurser47 June 23, 2025 18:31
Copy link
Member

@rpurser47 rpurser47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only change I'd make at this point is to make the instructions for packaging the toolbox more explicit.


The information about your toolbox is stored in a toolbox packaging file. Confusingly, this file has a `.prj` extension -- the same as a MATLAB project file. These files are not interchangeable. Because of this, we recommend that you name your packaging file `toolboxPackaging.prj` and put it in the root folder. To make it clear which icon image file will be used, we recommend that you symmetrically name this file `toolboxPackaging.jpg` and put it in the `images` folder. These files should be under source control.
Note that the tools for packaging a toolbox changed in R2025a:
* Starting in R2025a, Toolbox packaging files are created using the Package Toolbox task with MATLAB Projects. Give the project file (with a `.prj` extension) the same name as the root folder. Put it in the root folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be more step by step about how to do this. I don't think "the Package Toolbox task with MATLAB Projects" will mean much to most people, especially if they don't have a project. I think the easiest way (which works both before and after R2025a) is to go to the Home tab, and in the Environment section, select Add-Ons > Package Toolbox. If they don't have a project, it'll be created for them.


Toolbox packaging files are created using the Toolbox Packaging Tool. In MATLAB, go to the home tab, drop the "Add-Ons" menu, and choose "Package Toolbox."
Name your toolbox icon image file `toolboxPackaging.jpg` and put it in the `images` folder. The project files and toolbox icon image file should be under source control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth changing, but I'd suggest that they name the image the same as the root folder and the project file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"internal" folder doesn't achieve it's desired objectives gettingStarted.mlx should be GettingStarted.mlx
3 participants