Skip to content

Conversation

watermarkhu
Copy link
Contributor

The removed lines were probably copied from

<string>(?&lt;![a-zA-Z0-9_]|\.)[a-zA-Z][a-zA-Z0-9_]*(?:\.[a-zA-Z][a-zA-Z0-9_]*)*(?![a-zA-Z0-9_]|(?:\(|\{|\.\())</string>

The negative lookahead on [a-zA-Z0-9_] does nothing due to the [a-zA-Z0-9_]* just before.

@dklilley
Copy link
Member

dklilley commented Sep 6, 2023

Trying this out on regex101, it appears that there is a difference in behavior. The original property regex matches asd in foo.asd, but does not match it in foo.asd(. However, the new regex matches as in foo.asd(.

Can you confirm?

@watermarkhu
Copy link
Contributor Author

This seems indeed to be the case. I'll add a test to this PR instead.

@dklilley
Copy link
Member

dklilley commented Nov 8, 2023

Hi Mark, sorry for the delay in getting back to this. What is the current status of this PR? It looks like the only change right now is to a test file.

@watermarkhu
Copy link
Contributor Author

watermarkhu commented Nov 8, 2023

Hi Duncan,
The original edit was invalid. But there also wasn't a test to check for the behavior as you indicated. So the edit is disregarded but a test has been added.

@dklilley
Copy link
Member

dklilley commented Nov 9, 2023

Makes sense, thank you!

@dklilley dklilley merged commit d28a77e into mathworks:master Nov 9, 2023
@dklilley dklilley added the CLA signed Indicates that the requester has signed the Contributor License Agreement label Nov 9, 2023
@watermarkhu watermarkhu deleted the simplify_readwrite_operations branch December 16, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed Indicates that the requester has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants