Skip to content

Angular build#1078

Open
puschie286 wants to merge 9 commits intomathuo:masterfrom
puschie286:angular-build-fix
Open

Angular build#1078
puschie286 wants to merge 9 commits intomathuo:masterfrom
puschie286:angular-build-fix

Conversation

@puschie286
Copy link

The angular packages lack all angular metadata. Its compiled as regular typescript project.

This PR add an angular build (using ng-packagr) that includes all required metadata for direct usage in angular projects.

Changes:

  • Update all angular related packages to same version (v21)
  • Create angular build script and add to overall build

~ use same angular version in base package.json
~ update yarn lock for angular package changes
~ run (full) yarn install
~ update ng-packagr to matching angular version (v21)
~ update typescript to 5.9.3 (angular require >5.9)
~ update yarn lock
+ create cjs tsconfig
~ use cjs tsconfig for cjs build
~ fix ng-package config
+ create build script for generating angular build
~ add angular build to full build
@puschie286
Copy link
Author

Had 2 questions while working on this:

  1. Im not sure how useful it is to have amd/esm/cjs builds for an angular package. Maybe we can remove them and simplify the build process ?
  2. Can we update 'typedoc' to > 0.28 ? The current version is not compatible with typescript 5.9, which is the min version for angular 21

@mathuo

~ use node 20 for ci (min required for angular 21)
~ revert used angular version back to v17
~ revert other related packages back
~ ensure compatible typescript version is used
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 27, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d43e167:

Sandbox Source
dockview-app Configuration
editor-gridview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
nativeapp-dockview Configuration
rendering-dockview Configuration

@puschie286
Copy link
Author

Lowered the version back to v17 (how it was previous) to keep the same compatibility and prevent breaking changes for now.

There should be a plan about when framework versions are updated. v17 is very old (not supported anymore) and limit the usage of angular features (might have some incompatibilities with newer version in the future).

@mathuo
Copy link
Owner

mathuo commented Jan 27, 2026

Had 2 questions while working on this:

  1. Im not sure how useful it is to have amd/esm/cjs builds for an angular package. Maybe we can remove them and simplify the build process ?
  2. Can we update 'typedoc' to > 0.28 ? The current version is not compatible with typescript 5.9, which is the min version for angular 21

@mathuo

  1. Largely copied from the other framework packages, I'm not a huge fan of publishing them either but they are currently kept to allow usuage directly in html files within script tag. My professional experience with angular is very limited so I'm not entirely sure whether this is even possible in angular? if angular has a compile step then I assume not
  2. Happy to update any required packages included typescript, provided we don't use any breaking type changes.

@mathuo
Copy link
Owner

mathuo commented Jan 27, 2026

Lowered the version back to v17 (how it was previous) to keep the same compatibility and prevent breaking changes for now.

There should be a plan about when framework versions are updated. v17 is very old (not supported anymore) and limit the usage of angular features (might have some incompatibilities with newer version in the future).

I'm happy to bump to a more recent angular version, if it's breaking then we can release under a major version tag.

- remove cjs & (manual) esm build configs
- remove non angular build scripts
- remove build bundle script (part of angular building)
- remove not relevant package.json entries
@puschie286
Copy link
Author

puschie286 commented Jan 28, 2026

  1. i dont think so, there are some edge cases (like usage within electron) but they would rather use the core package - so i dont see any use in a dedicated angular package.
  2. did a quick test and the some things changed in the api.output.json but the docs seem fine on the first look

Sounds good - i prepare the APF only build for now and we will wait till v5 with changing angular to min v21

~ use partial build mode for better compatibility with different angular versions
- remove left over rollup script
@puschie286
Copy link
Author

PR is ready to merge

@mathuo feel free to ask for any assistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants