-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anchor parameter to DisplayText #313
Conversation
Hi @hchargois |
0d2b419
to
80cc79d
Compare
Rebase is done :) |
Is it possible to run these tests locally? |
The anchor parameter is required to easily (and correctly) placing text on the drawn image. See https://pillow.readthedocs.io/en/stable/handbook/text-anchors.html
80cc79d
to
4057b0d
Compare
So, what was done manually before this PR, i.e. computing the empty "margins" around the drawn text via a call to So I just added that anchor to the drawing functions for the themes. I was able to run the github action locally and confirm that all screencaps are now exactly the same as before. IMO, I think the library's However, this does mean that people who are using |
Thanks for the changes, I agree it is best to have the anchor default to |
The anchor parameter is required to easily (and correctly) place text on the drawn image.
See https://pillow.readthedocs.io/en/stable/handbook/text-anchors.html