Move mathjax-full to a dev-dependency. #2242

[dpvc]

Change mathjax-full dependency to a devDependency, so mathjax-full (and its dependencies) are not loaded when mathjax is included in a node project.

Resolves issue #2242

[ggrossetie]

LGTM 😉

[chiptus]

can mathjax-full be loaded from npm instead of git?

[ggrossetie]

can mathjax-full be loaded from npm instead of git?

That would be even better since the package is published on npmjs: https://www.npmjs.com/package/mathjax-full

But it might change the release process a little bit because you would have to:

1. release mathjax-full (for instance version 3.0.1)
2. edit the package.json in this repository to update the version of mathjax-full (to version 3.0.1)
3. release mathjax

[chiptus]

you can pin the version i.e mathjax-full: "3", no? sounds even better than using the git repo as it's not pinned

[chiptus]

quick fix for people who need this to be loaded from the npm repo and are using yarn:
add this to your package.json:

{
  ...other package.json things,
  "resolutions": {
     "mathjax-full": "3"
  }
}

[ggrossetie]

@chiptus Do you know if there's a workaround for npm?

[chiptus]

Maybe https://github.com/rogeriochaves/npm-force-resolutions

[dpvc]

I've updated to use the mathjax-full package, as @Mogztter suggested. The es5 directory is already included in that package, so we can just copy that one rather than building it directly. The package.json has to be edited to update its version anyway, so it is no problem to adjust the mathjax-full version as well at that time.

We are preparing a v3.0.1 release, and these changes will be used for that version.

[ggrossetie]

Excellent ! Thanks @dpvc

[chiptus]

Thanks!

…

On Fri, 7 Feb 2020, 18:53 Guillaume Grossetie, ***@***.***> wrote: Excellent ! Thanks @dpvc <https://github.com/dpvc> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2244?email_source=notifications&email_token=AAKRKFZUXWKUDKXSXVZTWV3RBWNYDA5CNFSM4JPERLLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD6R7Q#issuecomment-583526654>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKRKF7CRVDEMYAJ4RM76U3RBWNYDANCNFSM4JPERLLA> .