Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Math Processing Error] with empty mmultiscripts in Native MathML mode #486

Closed
fred-wang opened this issue May 29, 2013 · 11 comments
Closed
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.3
Milestone

Comments

@fred-wang
Copy link
Contributor

 <math><mmultiscripts></mmultiscripts></math>

leads to a [Math Processing Error] with the Native MathML mode. This is invalid MathML but normally MathJax should pass it to the browser and let the native MathML code handle the error.

@dpvc
Copy link
Member

dpvc commented May 29, 2013

The issue486 branch of my fork of MathJax includes a fix.

@fred-wang
Copy link
Contributor Author

OK, looks good. A quick look at the source shows that a similar processing error will happen with

 <math><munder></munder></math>
 <math><mtable><mlabeledtr></mlabeledtr></mtable>

so that would be good to fix them too while we are there.

@fred-wang
Copy link
Contributor Author

Crashtests/issue486.html

=> In testsuite

@dpvc
Copy link
Member

dpvc commented May 30, 2013

OK, I'll look into the other cases.

@fred-wang
Copy link
Contributor Author

=> Ready for release.

dpvc added a commit that referenced this issue Jul 31, 2013
@fred-wang
Copy link
Contributor Author

It seems that closing the issue increase the progress in the "Milestone" bar. Should we leave open issues marked "merge" (I don't remember why we waited the last minute before closing everything in the past)

@dpvc
Copy link
Member

dpvc commented Aug 2, 2013

The reason we had left them before was that it was easier to see at a glance what was actually going to be part of v2.2. This was before we had the labels for versions. Now that we have milestones, that probably isn't necessary. I think it is OK to close the issues when merged, and will start to do so.

@dpvc dpvc closed this as completed Aug 2, 2013
@fred-wang
Copy link
Contributor Author

What about the "Merged" label. Is it still necessary?

@pkra
Copy link
Contributor

pkra commented Aug 2, 2013

I'll create a "final" issue for the release (increasing versions, packing etc). That would prevent the milestone from closing automatically after technical bugs are closed -- and remind us to do the versions and packaging ;) .

@dpvc
Copy link
Member

dpvc commented Aug 2, 2013

I guess the merged label isn't really needed.

For the final issue, please include registering with Bower.

@pkra
Copy link
Contributor

pkra commented Aug 2, 2013

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.3
Projects
None yet
Development

No branches or pull requests

3 participants