-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing/sizing issues in "cases" environment #485
Comments
The |
It looks like you've left some debug logging in the source. |
Adding QA unit test wanted, just to remember that I must update LaTeXToMathML tests that rely on the cases construction (around 25). |
=> Ready For Release IIRC, this changes the reference of a lot of tests that use "cases" directly but also those that use it indirectly (like other environments based on cases). I hope this is what we want. If so, I'll update the references. |
None of the other environments currently use cases, so I think it will be OK. This makes cases conform to the TeX usage, so I do think it is what we want. We might want to check the other array environments to see if similar changes are needed there. Thanks for fixing the debugging call. |
When I executed the LaTeXToMathML tests on 2013-05-30 with that branch, I got failure with subarray, substack, binom due to a change of displaystyle. However, they do not seem to use case so I'm not sure what happened. I'll try to run the tests again. |
Most failing LaTeXToMathML tests still have a useless explicit displaystyle="false". |
We'll have to analyze more precisely why these explicit displaystyle="false" attribute now show up. But otherwise, I can just update the references. |
So if I understand correctly, we added
in the Array function of the input TeX. This is used for all Array environments, not just cases. Then in the native MathML output, NativeMMLattributes does not seem to compare with the default value but just to skip attributes that are "null". This means that displaystyle="false" will be generated. Is this intended? Should we fix that in MathJax? Or should I update the test references? |
@dpvc any idea? |
My recollection is that this is as intended. The environments where inheriting the displaystyle from setting outside the environment, and that is not what it supposed to happen. (The environment is supposed to typeset the same regardless of the style outside.) At the time the macro runs, the MathML is not yet completely available, and you can't tell for sure what displaystyle is in effect, so it seemed best to set it explicitly. I suppose it could be filtered out later, but I don't really see the need. |
OK, thanks. I'll just update the references. |
The following doesn't seem to render correctly. LaTeX itself shrinks the fraction.
The text was updated successfully, but these errors were encountered: