Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extensions #485

Merged
merged 11 commits into from
May 26, 2020
Merged

Rename extensions #485

merged 11 commits into from
May 26, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 9, 2020

This PR implements the renaming of tex extensions to normalize the names of the packages and their directories.

  • amsCd, ams_cd => amscd
  • colorV2, color_v2 => colorv2
  • configMacros, config_macros => configmacros
  • tagFormat, tag_format => tagformat

Note that git does not actual track renaming of files, so GitHub tries to work out the renaming that was done, but doesn't always get it right, here, since a number of the files are very similar. So there are some differences that may seem weird due to that.

I added code to the renamed components and to the dependencies file in order to make the current names still work in the new version. That involved not just making the loader load the new names using the old ones, but also fixing the package list when an old name appeared, and adjusting the preferences if the old name was used (e.g., tex.tagFormat preferences need to me moved to tex.tagformat).

@dpvc dpvc added this to the v3.1.0 milestone May 13, 2020
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Just one typo.


//
// Look for a package name in the package list and change it to a new name
// rhen rename tex options for it, if there are any.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Base automatically changed from pretty-components to pretty-code May 26, 2020 16:56
@dpvc dpvc changed the base branch from pretty-code to develop May 26, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants