Add tagFormat to AllPackes, and update the preloaded list. (mathjax/MathJax#2328) #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
requested changes
Mar 30, 2020
There was a problem hiding this comment.
I have a general problem here, which I must have missed in the initial code review of the TagFormat package:
The directory is tag_format, the filename is TagFormatConfiguration, the configuration function is tagFormatConfig, etc. But then the class is called Tagformat and the exported constant TagformatConfiguration.
I think it should be TagFormat in both cases to be less confusing. This way it is more in line with the other package (e.g., config_macros).
Could we use this PR to fix this?
|
OK, I'll take care of it. Sorry for the inconsistency. |
|
OK, I've made the change. Can you check that this is what you wanted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
tagFormatto the AllPackages file, and updates the preloaded list to include it (and andcolor_v2, which was loaded but missing from the list. Also, it addsbussproofsto the package list.Resolves issue mathjax/MathJax#2328.