Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Oct 29, 2025

This PR adds a default font size for the situation where the font size can't be computed, e.g, when the DOM element is not in an active DOM, or when it has display: none, rather than returning NaN.

Resolves issue mathjax/MathJax#3458.

@dpvc dpvc requested a review from zorkow October 29, 2025 17:23
@dpvc dpvc added this to the v4.1.0 milestone Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.66%. Comparing base (27c47f3) to head (a39c43a).

Files with missing lines Patch % Lines
ts/adaptors/HTMLAdaptor.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1380      +/-   ##
===========================================
- Coverage    86.66%   86.66%   -0.01%     
===========================================
  Files          338      338              
  Lines        84384    84394      +10     
  Branches      4779     3149    -1630     
===========================================
+ Hits         73131    73138       +7     
- Misses       11253    11256       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants