Skip to content

Commit

Permalink
updates to logic
Browse files Browse the repository at this point in the history
  • Loading branch information
swarty committed Dec 4, 2023
1 parent e6e8a82 commit 1472021
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/elements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,6 @@ export abstract class BaseView<T extends HTMLElement|SVGElement> {

// hack to avoid TS notification
// about setting undefined value to readonly properties
delete (node as any)._el;
delete (node as any)._data;

Check warning on line 610 in src/elements.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 16.x

Unexpected any. Specify a different type

Check warning on line 610 in src/elements.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 18.x

Unexpected any. Specify a different type
delete (node as any)._events;

Check warning on line 611 in src/elements.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 16.x

Unexpected any. Specify a different type

Check warning on line 611 in src/elements.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 18.x

Unexpected any. Specify a different type

Expand Down Expand Up @@ -734,8 +733,6 @@ export abstract class BaseView<T extends HTMLElement|SVGElement> {
* Bind an listener when element attribute changed
*/
onAttr(name: string, callback: (value: string, initial?: boolean) => void) {
// TODO Reuse existing observers, remove events, disconnect when deleting.

if (!this._mutationObserver) {
this._mutationObserver = new MutationObserver((mutations) => {
for (const m of mutations) {
Expand Down

0 comments on commit 1472021

Please sign in to comment.