✅🐛 Add tests and fix bugs for RelationsInModelFinder

src/Helpers/RelationsInModelFinder.php

@@ -8,9 +8,6 @@
 class RelationsInModelFinder
 {
     private $model;
-    /**
-     * @var
-     */
     private $relationsType;
 
     public function __construct(Model $model, array $relationsType)
@@ -19,22 +16,23 @@ public function __construct(Model $model, array $relationsType)
         $this->relationsType = $relationsType;
     }
 
-    public static function children(Model $model)
+    public static function hasOneOrMany(Model $model)
     {
-        return (new static($model, ['hasMany', 'hasManyThrough', 'hasOne']))->find();
+        return (new static($model, ['hasMany', 'hasOne']))->find();
     }
 
     protected function find()
     {
         return collect(get_class_methods($this->model))->sort()
             ->reject(function ($method) {
-                $this->isAnEloquentMethod($method);
+                return $this->isAnEloquentMethod($method);
             })->filter(function ($method) {
                 $code = $this->getMethodCode($method);
-                collect($this->relationsType)->contains(function ($relation) use ($code) {
+
+                return collect($this->relationsType)->contains(function ($relation) use ($code) {
                     return Str::contains($code, '$this->' . $relation . '(');
                 });
-            });
+            })->toArray();
     }
 
     protected function isAnEloquentMethod($method): bool

src/Traits/JsonExporter.php

@@ -47,7 +47,7 @@ public function exportRelations(): Collection
 
     public function getJsonExportableRelations(): array
     {
-        return $this->jsonExportableRelations ?? RelationsInModelFinder::children($this);
+        return $this->jsonExportableRelations ?? RelationsInModelFinder::hasOneOrMany($this);
     }
 
 

tests/Helpers/RelationsInModelFinderTest.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace MathieuTu\JsonImport\Tests\Helpers;
+
+use MathieuTu\JsonImport\Helpers\RelationsInModelFinder;
+
+class RelationsInModelFinderTest extends \PHPUnit\Framework\TestCase
+{
+    public function testhasOneOrMany()
+    {
+        $this->assertEquals(['foos', 'bar'], RelationsInModelFinder::hasOneOrMany(new MyModel()));
+    }
+}
+
+class MyModel extends \Illuminate\Database\Eloquent\Model
+{
+    public function foos()
+    {
+        return $this->hasMany('foo');
+    }
+
+    public function bar()
+    {
+        return $this->hasOne('bar');
+    }
+
+    public function baz()
+    {
+        return $this->hasManyThrough('baz', 'bar');
+    }
+
+    public function notARelation()
+    {
+        return 'this is not a relation!';
+    }
+
+    public function parent()
+    {
+        return $this->belongsTo('parent');
+    }
+
+}