fix loading logic #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If onClick() prop doesn't return promise, the button will stay in loading state forever
provide error in error handler
xakep139
commented
Mar 9, 2017
| this.state.currentState !== STATE.LOADING) && | ||
| this.state.currentState !== STATE.DISABLED | ||
| ) { | ||
| this.loading() |
There was a problem hiding this comment.
change state before calling handler
xakep139
commented
Mar 9, 2017
| this.setState({currentState: STATE.NOTHING}) | ||
| callback = callback || this.props.onError | ||
| if (typeof callback === 'function') { callback() } | ||
| if (typeof callback === 'function') { callback(err) } |
There was a problem hiding this comment.
provide error object in callback
|
Thanks for the PR! Just to be clear, it only about calling |
|
If you make, for example, some synchronous checks in onClick() and decide to return button in state=STATE.NOTHING, it will suddenly start loading after that. |
|
oh yes good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If onClick() prop doesn't return promise, the button will stay in loading state forever;
additionally provide error object in handler