API Compatibility with AsyncWebSocketMessageBuffer and makeBuffer()
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
force-pushed
the
AsyncWebSocketMessageBuffer
branch
from
5cbcf4f
to
40db85d
Compare
|
FYI @vortigont |
|
These changes have been tested in an app doing a lot of WS calls and I see no memory leak.
spikes causes by more intensive tests. This is the used heap.
|
|
Looks pretty nice indeed! Thanks! |
|
Note that I didn't do any allocation verification on the pr : just a straightforward implementation. I will add more safety checks today - i.e. to return nullptr when the vector cannot be allocated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back API-compatibility to the original fork regarding the use of
AsyncWebSocketMessageBuffer.Note that this is not optimised since it wraps the shared buffer mechanism in this temporary class.
See discussion here about what has motivated this PR:
yubox-node-org#8 (comment)