Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for replacing a response by a new one #103

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Support for replacing a response by a new one #103

merged 2 commits into from
Sep 13, 2024

Conversation

mathieucarbou
Copy link
Owner

No description provided.

@mathieucarbou
Copy link
Owner Author

mathieucarbou commented Sep 13, 2024

This really simple PR allows for a very nice feat: ability to override a previously prepared response, in order tp build a new one.

the real sending will happen once the handle exist, not in the send method anymore.

this will allow to have middleware support for response headers too!

@mathieucarbou
Copy link
Owner Author

@DRSDavidSoft: FYI

@mathieucarbou mathieucarbou merged commit ca82a3e into main Sep 13, 2024
46 checks passed
@DRSDavidSoft
Copy link

@mathieucarbou Wow, this is some excellent addition! How does it work internally? Also, what was the previous behavior, for reference?

Thanks for adding this too! 👍🏻

@mathieucarbou
Copy link
Owner Author

@mathieucarbou Wow, this is some excellent addition! How does it work internally? Also, what was the previous behavior, for reference?

Look at the code ;-)

@mathieucarbou mathieucarbou deleted the response branch October 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants