Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Checksum algorithm shall force 0x00 value to 0xFF #28

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

mathieu-mp
Copy link
Owner

@mathieu-mp mathieu-mp commented Jul 2, 2023

0x00 checksum value is reserved for "checksum not calculated" and should be forced to 0xFF

@mathieu-mp mathieu-mp linked an issue Jul 2, 2023 that may be closed by this pull request
@mathieu-mp mathieu-mp self-assigned this Jul 2, 2023
@mathieu-mp mathieu-mp added the Bug label Jul 2, 2023
@mathieu-mp mathieu-mp changed the title Checksum value 0x00 is reserved for checksum not calculated Fix: Checksum algorithm shall convert value 0x00 to 0xFF Jul 2, 2023
@mathieu-mp mathieu-mp changed the title Fix: Checksum algorithm shall convert value 0x00 to 0xFF Fix: Checksum algorithm shall force 0x00 value to 0xFF Jul 2, 2023
@mathieu-mp mathieu-mp marked this pull request as ready for review July 2, 2023 09:58
@mathieu-mp mathieu-mp merged commit fbe59a0 into main Jul 2, 2023
@mathieu-mp mathieu-mp deleted the 27-checksum-0x00-is-reserved branch July 2, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum algorithm fails on 0xFF legitimate checksum
1 participant