Add visual cues to FK column header #1388
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950
Before this PR
Design I followed
I'm roughly following the design in the prototype:
After this PR
Notes
Small improvisation: I added a link icon to the FK column and a key icon to the PK column to designate the constraints. We can get rid of these if needed.
I had to make the column header a bit taller to account fot the extra line. I chose to keep its current height when the table has no foreign keys. Not sure if that's the best approach though.
I'm not sure of the best way to delimit the table name from the column name. In Show detailed FK info in constraints dialog #1383 I used an icon. That didn't look so good here. And I wanted to share the code between the two UI locations, so I converted them both to dots. In theory a user could have a table name containing a dot which could create confusion when reading the table name and column name. Though perhaps that's unlikely enough to discount. In the end, I chose to follow the prototype. I figure we can think harder about this after getting user feedback.
Checklist
Update index.md
).master
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin