Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual cues to FK column header #1388

Closed
wants to merge 7 commits into from
Closed

Conversation

seancolsen
Copy link
Contributor

Fixes #950

Before this PR

image

Design I followed

I'm roughly following the design in the prototype:

image

After this PR

image

Notes

  • Small improvisation: I added a link icon to the FK column and a key icon to the PK column to designate the constraints. We can get rid of these if needed.

  • I had to make the column header a bit taller to account fot the extra line. I chose to keep its current height when the table has no foreign keys. Not sure if that's the best approach though.

  • I'm not sure of the best way to delimit the table name from the column name. In Show detailed FK info in constraints dialog #1383 I used an icon. That didn't look so good here. And I wanted to share the code between the two UI locations, so I converted them both to dots. In theory a user could have a table name containing a dot which could create confusion when reading the table name and column name. Though perhaps that's unlikely enough to discount. In the end, I chose to follow the prototype. I figure we can think harder about this after getting user feedback.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen requested review from a team and pavish and removed request for a team May 18, 2022 22:07
@seancolsen seancolsen added pr-status: review A PR awaiting review and removed pr-status: review A PR awaiting review labels May 18, 2022
@seancolsen seancolsen marked this pull request as draft May 18, 2022 22:09
@seancolsen
Copy link
Contributor Author

Whoops -- This is ready, but should be marked as a draft because it's based on #1383

@codecov-commenter

This comment was marked as off-topic.

@pavish pavish marked this pull request as ready for review May 24, 2022 16:36
Base automatically changed from 949_fk_list_detail to master May 24, 2022 16:37
@pavish pavish self-assigned this May 24, 2022
@seancolsen seancolsen added the pr-status: review A PR awaiting review label May 27, 2022
@seancolsen
Copy link
Contributor Author

I'm closing this PR per a discucsion where we decided to pursue a simpler design.

@seancolsen seancolsen closed this Jul 27, 2022
@kgodey kgodey deleted the 950_fk_visual_cues branch July 27, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add visual cues to foreign key columns
3 participants