Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event dispatcher in columnStore to fetch rows on adding new column #1256

Conversation

shrey27tri01
Copy link
Contributor

Fixes #1120

Technical details

Added an event dispatcher to columns.ts, to tabularData.ts on adding a column, so that when a new column is added, tabularData.ts fetches the rows and the NULL values are reflected on the rows in the new column

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shrey27tri01 shrey27tri01 requested review from a team and seancolsen March 31, 2022 14:03
@codecov-commenter
Copy link

Codecov Report

Merging #1256 (f085b64) into master (2e80bd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         113      113           
  Lines        4330     4330           
=======================================
  Hits         4045     4045           
  Misses        285      285           
Flag Coverage Δ
pytest-backend 93.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e80bd9...f085b64. Read the comment docs.

Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @shrey27tri01!

@seancolsen seancolsen enabled auto-merge April 4, 2022 13:28
@seancolsen seancolsen merged commit 5f0eb2c into mathesar-foundation:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

NULL values do not display within newly-added column
3 participants