-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace empty column name with "column_X" #1255
replace empty column name with "column_X" #1255
Conversation
We should probably use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case to confirm if the PR solves the issue or mention an existing test case that can confirm the behaviour?
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 93.41% 93.42%
=======================================
Files 113 113
Lines 4330 4332 +2
=======================================
+ Hits 4045 4047 +2
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@silentninja I added a new unit test. @kgodey I made the changes you asked for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice work! @A1O.
Fixes #1003
Now all csv files are treated as headed files for preview. This pull request generates a column name "column_X" for empty column name.
Technical details
Other possible solution is to import csv file as headless file by default.
Screenshots
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin