Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1189] - Number 0 should show in table cell #1254

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

muhsinkamil
Copy link
Contributor

@muhsinkamil muhsinkamil commented Mar 30, 2022

Fixes #1189

Technical details

  • Since the number 0 fails at if check, added OR to fix it

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@muhsinkamil muhsinkamil marked this pull request as ready for review March 31, 2022 08:25
@muhsinkamil muhsinkamil requested review from a team and pavish March 31, 2022 08:25
@pavish pavish self-assigned this Mar 31, 2022
@pavish pavish added the pr-status: review A PR awaiting review label Mar 31, 2022
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhsinkamil Thanks for the PR! I have a comment, upon resolving it, we can merge this PR in.

@pavish pavish assigned muhsinkamil and unassigned pavish Apr 4, 2022
@pavish pavish added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Apr 4, 2022
@muhsinkamil muhsinkamil requested a review from pavish April 4, 2022 05:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #1254 (f5797d5) into master (abe9cf7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1254   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         113      113           
  Lines        4330     4330           
=======================================
  Hits         4045     4045           
  Misses        285      285           
Flag Coverage Δ
pytest-backend 93.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe9cf7...f5797d5. Read the comment docs.

@pavish pavish assigned pavish and unassigned muhsinkamil Apr 4, 2022
@pavish pavish added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Apr 4, 2022
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhsinkamil Thanks for your work on this PR. Looks good to me!

@pavish pavish enabled auto-merge April 4, 2022 11:06
@pavish pavish merged commit 9bc3ae5 into mathesar-foundation:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

A number type column doesn't show '0' value
3 participants