-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1189] - Number 0 should show in table cell #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muhsinkamil Thanks for the PR! I have a comment, upon resolving it, we can merge this PR in.
mathesar_ui/src/components/cell/cell-types/common/SteppedInputCell.svelte
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 113 113
Lines 4330 4330
=======================================
Hits 4045 4045
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muhsinkamil Thanks for your work on this PR. Looks good to me!
Fixes #1189
Technical details
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin