-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display options groundwork & config for boolean, number #1239
Conversation
… type config files
…on display and db
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 113 113
Lines 4328 4328
=======================================
Hits 4043 4043
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…ofci/mathesar into display_options
I'm stacking this over #1240, to avoid merge conflicts. |
I'll review this, but I want to wait until we resolve #1243 first |
@seancolsen This PR is mostly groundwork on display options. The whole number configuration is one file: I added both boolean and number display options in this PR, so that we can view the usage on the product. Even tests haven't been added yet and will be added as part of each individual data types issue. If #1243 takes longer, I'd suggest reviewing and merging this one. If we decide on different options for number, we can make that change in the Number type implementation issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The validation stuff (and behavior with respect to the tabs) is very slick. Nice work!
Related to: #257, #258
This PR:
Screenshots:
Boolean display options
Number display options
* The formats listed here are as per conversations over the past week in the Matrix channels.
Validation
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin