Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type logic refactor #1222

Merged
merged 84 commits into from
May 24, 2022
Merged
Changes from 1 commit
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
af4fa7c
add db type alias information to db types endpoint
dmos62 Mar 17, 2022
41c6623
fix set membership test
dmos62 Mar 17, 2022
9b294c8
Merge branch 'master' into add_alias_info_to_db_types_endpoint
dmos62 Mar 17, 2022
10bf354
Exploratory comments and minor refactor
dmos62 Mar 17, 2022
d644c37
Some more slight refactors and comments
dmos62 Mar 17, 2022
b52b3ab
+
dmos62 Mar 18, 2022
57cf327
Fix None filtering
dmos62 Mar 18, 2022
95595e3
Merge branch 'add_alias_info_to_db_types_endpoint' into some-type-log…
dmos62 Mar 18, 2022
d98271d
Add utilities to DatabaseType for looking up its ischema key
dmos62 Mar 18, 2022
9264c0d
Linter fixes
dmos62 Mar 18, 2022
9576f27
Minor refactor
dmos62 Mar 21, 2022
430c8af
Add get_sa_class method to DatabaseType
dmos62 Mar 21, 2022
f0517e8
Get rid of aliases information from DatabaseType
dmos62 Mar 21, 2022
754e793
Access ischema_names dict directly
dmos62 Mar 21, 2022
da659d3
Add DatabaseType::is_available_on_engine
dmos62 Mar 21, 2022
e5023cb
Delete get_available_types, some constants
dmos62 Mar 21, 2022
69fc2b2
Various type-related refactors
dmos62 Mar 23, 2022
c2357fe
Remove leftover aliases namespace
dmos62 Mar 23, 2022
0fd467e
Minor refactor
dmos62 Mar 23, 2022
3a73895
Linter fixes
dmos62 Mar 23, 2022
4a9aa6d
Merge branch 'master' into some-type-logic-refactor
dmos62 Mar 24, 2022
e614e2c
Remove other aliases remnants
dmos62 Mar 24, 2022
278d885
Minor changes
dmos62 Mar 24, 2022
50a4425
Various fixes
dmos62 Mar 24, 2022
5f3044a
Convert group of tests into a single parametrized test
dmos62 Mar 24, 2022
d39a436
Revert to using multiple tests
dmos62 Mar 24, 2022
898cd73
More refactoring
dmos62 Mar 25, 2022
4f4cb7a
Various refactors
dmos62 Mar 25, 2022
1ad0fb3
columns test_alter.py passing
dmos62 Mar 29, 2022
38156a4
A few more suites are passing; currently working on types test_cast
dmos62 Mar 31, 2022
dd8b004
Merge branch 'master' into some-type-logic-refactor
dmos62 Apr 14, 2022
6ff9d87
db/tests/types/ are passing
dmos62 Apr 21, 2022
ecb508d
db/tests/records/ is passing
dmos62 Apr 21, 2022
0b224ef
db/tests/tables/ is passing
dmos62 Apr 21, 2022
dab7c5c
add previously renamed file
dmos62 Apr 21, 2022
79db6be
db/tests/ passing
dmos62 Apr 21, 2022
29d792a
some initial changes to mathesar ns
dmos62 Apr 21, 2022
d0e8a8c
mathesar/tests/api/test_column_api.py passing
dmos62 Apr 27, 2022
d23a2d3
mathesar/tests/api/test_data_file_api.py is passing
dmos62 Apr 27, 2022
8752637
fix more mathesar namespace tests
dmos62 Apr 29, 2022
350e03a
All mathesar namespace tests are passing
dmos62 May 1, 2022
050534b
Fix last failing (non-integration) test
dmos62 May 1, 2022
7892e3e
Satisfy flake8
dmos62 May 1, 2022
88844cf
Merge branch 'master' into some-type-logic-refactor
dmos62 May 1, 2022
9047c2b
Refactor/fix number validation
dmos62 May 2, 2022
a81398c
Some post-merge test fixes
dmos62 May 2, 2022
6540b3b
Satisfy flake8
dmos62 May 2, 2022
beb365f
Undo accidental search and replace on a mathesar_ui file
dmos62 May 2, 2022
b2e988b
Fix whitespace
dmos62 May 2, 2022
cedd891
Remove dead code
dmos62 May 2, 2022
7f5d331
Typo
dmos62 May 2, 2022
8317427
Update integ. tests and fixtures
dmos62 May 3, 2022
d107bf8
Update frontend UI type configs
dmos62 May 3, 2022
902267a
Merge branch 'master' into some-type-logic-refactor
dmos62 May 3, 2022
58887d2
Have Dockerfile setting survive rebuilds
dmos62 May 5, 2022
952aeea
Fix some tests
dmos62 May 6, 2022
25c9f6f
Minor changes
dmos62 May 9, 2022
ff23257
Some merge conflict and bug fixes
dmos62 May 16, 2022
6c2ef2c
Some minor changes; enabled model reset for all mathesar tests
dmos62 May 16, 2022
d08a5af
Reduce fixture scope
dmos62 May 17, 2022
d33efb8
Add sqlalchemy_utils to requirements
dmos62 May 17, 2022
e0d9fd3
Make django test database short lived
dmos62 May 17, 2022
0873b11
Support xdist testing; optimize fixture scopes for performance
dmos62 May 19, 2022
6b5561f
Merge branch 'master' into some-type-logic-refactor
dmos62 May 20, 2022
cf911cc
Add xdist to requirements-dev.txt
dmos62 May 20, 2022
07fc8fc
Many merge conflict fixes and refactors
dmos62 May 20, 2022
3696692
Fix display options serializer
dmos62 May 23, 2022
f2cec65
Various fixes
dmos62 May 23, 2022
305556f
Merge branch 'master' into some-type-logic-refactor
dmos62 May 23, 2022
3bd9c7a
Remove logging from fixtures
dmos62 May 23, 2022
b4dc592
Minor changes
dmos62 May 23, 2022
eecdfae
Linter fixes
dmos62 May 23, 2022
8357b6e
Skip a hard-to-fix e2e test
dmos62 May 23, 2022
ec16cc3
Vulture fixes
dmos62 May 23, 2022
f8ff2cb
Linter fixes
dmos62 May 23, 2022
0708bc0
Add -n auto to setup.cfg so that tests run in parallel automatically
dmos62 May 23, 2022
dc03636
Disable xdist for e2e tests
dmos62 May 24, 2022
b133c4f
Get rid of non-canonical DatabaseTypes
dmos62 May 24, 2022
62fa079
Remove is_alias DatabaseType property
dmos62 May 24, 2022
7cdfa7c
Update E2E setup docs
seancolsen May 24, 2022
91adbb7
Use correct case for URI type
seancolsen May 24, 2022
bfcf549
Disable automatic test parallelization: fails with >7 threads
dmos62 May 24, 2022
80b368e
Merge branch 'some-type-logic-refactor' of github.com:centerofci/math…
dmos62 May 24, 2022
1b53d4c
Merge branch 'master' into some-type-logic-refactor
dmos62 May 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove other aliases remnants
  • Loading branch information
dmos62 committed Mar 24, 2022
commit e614e2c7af133287ad8b0b8636b28d947105bd95
4 changes: 0 additions & 4 deletions mathesar/api/serializers/db_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ def to_representation(self, db_type):
# TODO solve db type casing holistically
# https://github.com/centerofci/mathesar/issues/1036
uppercase_id = db_type.value.upper()
uppercased_aliases = [db_type_id.upper() for db_type_id in db_type.aliases]
uppercased_alias_of = db_type.alias_of.upper() if db_type.alias_of else None
return {
"id": uppercase_id,
"aliases": uppercased_aliases,
"alias_of": uppercased_alias_of,
"hints": db_types_hinted.get(db_type, None),
}