Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend support for tables without single-column primary keys #395

Closed
kgodey opened this issue Jul 16, 2021 · 3 comments
Closed

Backend support for tables without single-column primary keys #395

kgodey opened this issue Jul 16, 2021 · 3 comments
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 16, 2021

Problem

Currently, our Record API only works with tables with single-column primary keys. We need to explicitly handle tables without primary keys or with multi-column primary keys to prevent unexpected behavior or errors.

Proposed solution

We need to:

  • disable the record detail views (read, edit, delete) for records without primary keys.
  • disable the record detail views (read, edit, delete) for records with multi-column primary keys.
  • add a field to the TableSerializer (and therefore the table API) that indicates the type of primary key that a table has, so that the frontend can handle displaying it properly.

Additional context

@kgodey kgodey added type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL ready Ready for implementation labels Jul 16, 2021
@kgodey kgodey added this to the 10. Multiple Database Support milestone Jul 16, 2021
@kgodey kgodey added help wanted Community contributors can implement this good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. labels Jul 16, 2021
@aaditkamat
Copy link

Hi @kgodey, can I take up this issue?

@kgodey
Copy link
Contributor Author

kgodey commented Jul 31, 2021

@aaditkamat Yes, go ahead!

@kgodey kgodey added pr-status: review A PR awaiting review status: started and removed good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation pr-status: review A PR awaiting review labels Oct 12, 2021
@kgodey kgodey moved this from Review to Started in [NO LONGER USED] Mathesar work tracker Oct 12, 2021
@kgodey kgodey moved this from Started to Review in [NO LONGER USED] Mathesar work tracker Oct 12, 2021
@kgodey kgodey moved this from Review to Started in [NO LONGER USED] Mathesar work tracker Oct 12, 2021
@kgodey kgodey moved this from Started to Review in [NO LONGER USED] Mathesar work tracker Oct 12, 2021
@kgodey kgodey moved this from Review to Started in [NO LONGER USED] Mathesar work tracker Oct 12, 2021
@kgodey kgodey assigned kgodey and unassigned aaditkamat Oct 30, 2021
@kgodey kgodey removed their assignment Dec 4, 2021
@kgodey kgodey removed this from the [Beta] Multiple Database Support milestone Dec 14, 2021
@kgodey kgodey added this to the [12] Alpha Release milestone Dec 14, 2021
@kgodey kgodey added ready Ready for implementation and removed status: started labels Dec 14, 2021
@kgodey kgodey modified the milestones: [12] Alpha Release, [10] UI Styling Mar 29, 2022
@kgodey
Copy link
Contributor Author

kgodey commented Mar 29, 2022

I'll close this issue, we can figure out more detailed tickets once design work is done.

@kgodey kgodey closed this as completed Mar 29, 2022
Repository owner moved this from Ready to Done in [NO LONGER USED] Mathesar work tracker Mar 29, 2022
@kgodey kgodey removed this from the [10] UI Styling milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants