Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend support for tables without single-column primary keys #396

Closed
kgodey opened this issue Jul 16, 2021 · 3 comments
Closed

Frontend support for tables without single-column primary keys #396

kgodey opened this issue Jul 16, 2021 · 3 comments
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 16, 2021

Problem

Currently, we assume that tables have single-column primary keys. We need to explicitly handle tables without primary keys or with multi-column primary keys to prevent unexpected behavior or errors.

Proposed solution

We need to make the following changes in the frontend:

  • Disable infinite scroll for tables without primary keys or with multi-column primary keys. Pagination should be used instead.
  • Disable editing and deleting rows for tables without primary keys or with multi-column primary keys.
  • Show an informational message that tells users that some features are disabled because they have no primary key or a multi-column primary key.
    • If there is no primary key, we should show the user buttons that allow them to add a primary key field with one click or convert an existing field into a primary key field.

Additional context

@kgodey kgodey added the type: enhancement New feature or request label Jul 16, 2021
@kgodey kgodey added this to the 10. Multiple Database Support milestone Jul 16, 2021
@kgodey kgodey added needs: unblocking Blocked by other work work: frontend Related to frontend code in the mathesar_ui directory labels Jul 16, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Jul 16, 2021

@ghislaineguerin @pavish This seems like a small enough feature that we don't need a formal design for it; I suggest that when we get to it, @pavish can just implement it according to our general design patterns and @ghislaineguerin can review on the staging server and provide feedback.

@github-actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale label Oct 14, 2021
@pavish pavish removed the stale label Oct 14, 2021
@kgodey kgodey modified the milestones: [Beta] Multiple Database Support, [12] Alpha Release Dec 17, 2021
@kgodey kgodey modified the milestones: [12] Alpha Release, [10] UI Styling Mar 29, 2022
@kgodey
Copy link
Contributor Author

kgodey commented Mar 29, 2022

I'll close this issue, we can figure out more detailed tickets once design work is done.

@kgodey kgodey closed this as completed Mar 29, 2022
Repository owner moved this from Blocked to Done in [NO LONGER USED] Mathesar work tracker Mar 29, 2022
@kgodey kgodey removed this from the [10] UI Styling milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

2 participants