Install mathesar_types to full-fill some of the important db functions to work with e2e integ Testing

[ManishShah120]

Description

While running the e2e integration testing, integ environment is missing certain db functions, which doesn't allow the e2e environment to work with.

Expected behavior

All the front-end functionality should work exactly the same manner as working with any browser in the playwright browser or e2e testing environment.

To Reproduce

This issue was found while working on these e2e tests, please refer these links:-

• Add E2E test for converting a text column of numbers to a number column #1128
• Added integration tests for changing column type from text to number #1164

Environment

• OS: (eg. macOS 10.14.6; Fedora 32)
• Browser: (eg. Safari; Firefox; chromium)
• Browser Version: (eg. 13; 73)
• Other info:

Additional context

Please refere:-

• Add E2E test for converting a text column of numbers to a number column #1128

[kgodey]

@ManishShah120 are you working on this? I saw some messages in Matrix that might indicate that you are.

[ManishShah120]

Yes, @kgodey am working on it. It's a blocker for one of the other issue I am working on.

[kgodey]

Great thanks @ManishShah120, assigned to you.

[silentninja]

@ManishShah120 Few other issues(#1128, #1127) depend on this issue If you haven't started working on it, please let us know so that a core contributor can fix this issue.

[ManishShah120]

@ManishShah120 Few other issues(#1128, #1127) depend on this issue If you haven't started working on it, please let us know so that a core contributor can fix this issue.

Hi, @silentninja I was working on it(but not working at present), but then I found out that, the issue I faced can be solved, by passing patent_schema as an argument to the tests or fixture associated with it so was rethinking about this issue(may be there is no issue), and hence #1128 fixed with #1170 , I also tried to work on #1127 , in my case It got resolved, but #1182 is failing don't know why, should I open a PR, to make sure if it actually got fixed.

cc: @pavish

[silentninja]

@ManishShah120 That's not a proper solution, the reason why it works is that patent scheme is installing custom types https://github.com/centerofci/mathesar/blob/fbdfe75f5838d8948a540a6363f20654bf62c5b1/mathesar/tests/conftest.py#L136 when it is created. The proper solution is to use a schema like patent_schema which installs custom types instead of base_schema. base_schema should not be used for any test case which relies on custom types, the test cases would be misleading if done so.

[ManishShah120]

https://github.com/centerofci/mathesar/blob/fbdfe75f5838d8948a540a6363f20654bf62c5b1/mathesar/tests/conftest.py#L136

when it is created. The proper solution is to use a schema like patent_schema which installs custom types instead of base_schema. base_schema should not be used for any test case which relies on custom types, the test cases would be misleading if done so.

@silentninja I see. So do we need to do any of these:- 🤔

@pytest.fixture
def install_custom_type_schema(test_db_model):
    engine = create_mathesar_engine(test_db_model.name)
    install.install_mathesar_on_database(engine)

OR

@pytest.fixture
def install_custom_type_schema(test_db_model):
    engine = create_mathesar_engine(test_db_model.name)
    _add_custom_types_to_engine(engine)
    install.install_mathesar_on_database(engine)

and then pass these fixture wherever it is required 🤔

[silentninja]

@ManishShah120 Yes, that should be the correct way forward. The correct fixture is the first one as create_mathesar_engine does call _add_custom_types_to_engine when creating the engine, so additional call for _add_custom_types_to_engine is not necessary as done in the second fixture.

@pytest.fixture
def install_custom_type_schema(test_db_model):
    engine = create_mathesar_engine(test_db_model.name)
    install.install_mathesar_on_database(engine)

I would also look into renaming it to something like custom_types_schema instead of install_custom_type_schema as it returns a schema with custom types installed instead of installing custom types into a schema.