Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for converting a boolean column to a text column #1127

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 6 comments
Closed
Tracked by #1122

Add E2E test for converting a boolean column to a text column #1127

seancolsen opened this issue Mar 2, 2022 · 6 comments
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "converting a boolean column to a text column" works as-expected. Here's a visual demo of what the test should do:

Peek 2022-03-02 16-59

Tips

  • Assert that the text "true" and "false" display correctly
@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@sahilsaini1107
Copy link
Contributor

@seancolsen may you assign this issue to me.

@sahilsaini1107
Copy link
Contributor

Also, I want to ask one thing, how can we add true false entries in textarea while writing the test. As we are adding 2 and 3. May you please guide me with that.

page.fill("textarea", "foo,bar\n2,3")

@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 12, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 12, 2022

@sahilsaini110 I've assigned this to you. I see you have a few issues assigned already, please complete them first before asking to be assigned more issues.

@sahilsaini1107
Copy link
Contributor

Here is my code for the test.

I am unable to test it due to some errors may you tell me if it looks good to you or if there are any changes.

def test_convert_booleantype_to_texttype(page, base_schema_url):
page.goto(base_schema_url)
page.click("[aria-label='New Table']")
page.click("button:has-text('Import Data')")
page.click("text=Copy and Paste Text")
page.fill("textarea", "foo,bar\ntrue,false")
page.click("button:has-text('Continue')")
page.click("button:has-text('Finish Import')")
page.click("button:has-text('foo')")
page.click("text=Boolean")
page.click("button:has-text('Text')")
page.click("button:has-text('Save')")
expect(page.locator("text=true")).to_be_visible()
expect(page.locator("text=false")).to_be_visible()

@silentninja
Copy link
Contributor

@sahilsaini110 Create a PR, the CI will report the errors.

@kgodey kgodey moved this from Done to Review in [NO LONGER USED] Mathesar work tracker May 11, 2022
@kgodey kgodey moved this from Review to Started in [NO LONGER USED] Mathesar work tracker May 11, 2022
@kgodey kgodey modified the milestones: [08.1] 2022-05 improvements, Unprioritized Jun 1, 2022
@kgodey kgodey added ready Ready for implementation and removed status: started labels Jun 7, 2022
@kgodey
Copy link
Contributor

kgodey commented Jul 19, 2022

I'm going to close this since we've found E2E tests unreliable and don't want to be writing more.

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Repository owner moved this from Ready to Done in [NO LONGER USED] Mathesar work tracker Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
4 participants