Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for toggling an indeterminate checkbox to true, false, true #1131

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 4 comments · Fixed by #1204
Closed
Tracked by #1122

Add E2E test for toggling an indeterminate checkbox to true, false, true #1131

seancolsen opened this issue Mar 2, 2022 · 4 comments · Fixed by #1204
Assignees
@Cronus1007
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[06.1] 2022-03 im...

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "toggling an indeterminate checkbox to true, false, true" works as-expected. Here's a visual demo of what the test should do:

Peek 2022-03-02 17-09
@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@seancolsen seancolsen mentioned this issue Mar 2, 2022
Closed
9 tasks
@Cronus1007
Copy link
Contributor

@seancolsen Shall I work upon this issue?

@silentninja silentninja added status: started and removed ready Ready for implementation labels Mar 13, 2022
@silentninja
Copy link
Contributor

Thanks! @Cronus1007, I have assigned the issue to you. Let us know if you need any help.

@Cronus1007
Copy link
Contributor

@silentninja @kgodey Shall I create a new file under the tests/integration folder for this test or is there any such file which is most relevant with this type of test.

@seancolsen
Copy link
Contributor Author

@Cronus1007

Shall I create a new file under the tests/integration folder for this test or is there any such file which is most relevant with this type of test.

Good question. There's not really a strict scheme for organizing these E2E tests.

Here's an idea:

  1. Start a new file called test_cells.py.
  2. Add your new test there.
  3. Then also move test_edit_cell into that file.

@Cronus1007 Cronus1007 mentioned this issue Mar 21, 2022
Merged
7 tasks
Repository owner moved this from Started to Done in [NO LONGER USED] Mathesar work tracker Mar 30, 2022
seancolsen added a commit that referenced this issue Mar 30, 2022
@seancolsen
Merge pull request #1204 from Cronus1007/issue#1131
e2ab941 
Fixes #1131 - Add E2E tests for checking the toggle button
@kgodey kgodey modified the milestones: [9.1] 2022-05 improvements, [06.1] 2022-03 improvements Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cronus1007 Cronus1007

Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[06.1] 2022-03 improvements
Development

Successfully merging a pull request may close this issue.

Fixes #1131 - Add E2E tests for checking the toggle button
4 participants
@seancolsen @kgodey @silentninja @Cronus1007