Merged
Conversation
Contributor
|
There seems to be no documentation on how to use the new feature. Also, it seems not to allow for a non zero normal component vector. Is it too difficult to add? I'd like to be able to sai u.N = f instead of only u.N = 0... |
Contributor
|
👍 for the feature! :) |
asartori86
force-pushed
the
no_normal_flux
branch
from
6d3ad28 to
0b1dbe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the possibility to specify the normal component appending the suffix "N" after the variable name. (see test
In parsed_dirichlet_bcs, the function
VectorTools::compute_no_normal_flux_constraintshas been wrapped.