Conversation
Updated the README to reflect PINA modules structure and added flowcharts for steps to follow.
Code Coverage SummaryResults for commit: 3209ce9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
GiovanniCanali
left a comment
There was a problem hiding this comment.
Very nice feature!
Unfortunately, the links in the diagram do not properly represent the structure in PINA. For instance, pina.optim does not depend upon pina.solver. The vast majority of modules depend directly on pina. Is there a way to make this without having a diagram which is too wide?
Yeah, I just tried to make a diagramm similar to the API image, but the structure should be a little bit different. We can also have "invisible" edges if needed. My only focus here is changing static to dynamic! |
GiovanniCanali
left a comment
There was a problem hiding this comment.
Everything looks good.
Up to you, @ndem0, whether you’d prefer to update the graph structure later or include it in this PR.
|
Very nice! I agree with @GiovanniCanali that some arrows are not completely right, but I like the idea to have something that it is easy to change for the future. Personally we can merge now and update it before 0.3 release |
Updated the README to reflect PINA modules structure and added flowcharts for steps to follow.
Description
This PR replaces the static PNG diagram in the README with an equivalent Mermaid (link) diagram.
The goal is to make the architecture diagram easier to maintain and update over time, avoiding the need to regenerate image assets for small documentation changes. The new Mermaid diagram mirrors the original structure and module hierarchy and is fully compatible with GitHub rendering.
Checklist