Skip to content

Neural Tangent Kernel integration + typo fix#505

Merged
ndem0 merged 16 commits into0.2from
weights
Mar 19, 2025
Merged

Neural Tangent Kernel integration + typo fix#505
ndem0 merged 16 commits into0.2from
weights

Conversation

@AleDinve
Copy link
Contributor

@AleDinve AleDinve commented Mar 17, 2025

Neural Tangent Kernel has been added as a weighting scheme.
Added files:

  • ntk_weighting.py: file containing the class Neural_Tangent_Kernel
  • test_ntk_weighting.py: file containing the basic tests for the class Neural_Tangent_Kernel

Added constructor for Neural_Tangent_Kernel in loss/init.py

Fixed typos in the following files:

  • scalar_weighting.py
  • weighting_interface.py

@AleDinve AleDinve requested review from dario-coscia and ndem0 March 17, 2025 20:19
@AleDinve AleDinve changed the base branch from master to 0.2 March 17, 2025 20:38
@AleDinve AleDinve self-assigned this Mar 17, 2025
@dario-coscia
Copy link
Collaborator

dario-coscia commented Mar 18, 2025

Hi @AleDinve! Thanks for the PR. Before reviewing:

  • remove the changes in the scalar_weighting and weighting_interface by restoring the files
  • format the code by running the formatter bash code_formatter.sh
  • add documentation to the py files

@dario-coscia dario-coscia added pr-to-fix Label for PR that needs modification v0.2 labels Mar 18, 2025
dario-coscia
dario-coscia requested changes Mar 18, 2025
View reviewed changes
@dario-coscia
Copy link
Collaborator

dario-coscia commented Mar 19, 2025

Hi! All checked are failing

@AleDinve
Copy link
Contributor Author

AleDinve commented Mar 19, 2025

Hi! Now all tests are successful

@ndem0
Copy link
Member

ndem0 commented Mar 19, 2025

Great for me!

dario-coscia
dario-coscia requested changes Mar 19, 2025
View reviewed changes
@ndem0 ndem0 merged commit 1f5126e into 0.2 Mar 19, 2025
16 of 18 checks passed
ndem0 pushed a commit that referenced this pull request Mar 19, 2025
@AleDinve @dario-coscia @ndem0
Neural Tangent Kernel integration + typo fix (#505)
716d43f 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
@dario-coscia dario-coscia deleted the weights branch March 20, 2025 09:46
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Mar 21, 2025
@AleDinve @dario-coscia @FilippoOlivo
Neural Tangent Kernel integration + typo fix (mathLab#505)
7d6e51d 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Mar 21, 2025
@AleDinve @dario-coscia @FilippoOlivo
Neural Tangent Kernel integration + typo fix (mathLab#505)
eaef9fa 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Mar 21, 2025
@AleDinve @dario-coscia @FilippoOlivo
Neural Tangent Kernel integration + typo fix (mathLab#505)
3620244 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Mar 21, 2025
@AleDinve @dario-coscia @FilippoOlivo
Neural Tangent Kernel integration + typo fix (mathLab#505)
948bf8f 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Apr 17, 2025
@AleDinve @dario-coscia @FilippoOlivo
Neural Tangent Kernel integration + typo fix (mathLab#505)
01aeb17 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
dario-coscia added a commit that referenced this pull request Apr 17, 2025
@AleDinve @dario-coscia
Neural Tangent Kernel integration + typo fix (#505)
d842d6f 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
GiovanniCanali pushed a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@AleDinve @dario-coscia @GiovanniCanali
Neural Tangent Kernel integration + typo fix (mathLab#505)
7b07d4e 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
GiovanniCanali pushed a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@AleDinve @dario-coscia @GiovanniCanali
Neural Tangent Kernel integration + typo fix (mathLab#505)
fce2ced 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
GiovanniCanali pushed a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@AleDinve @dario-coscia @GiovanniCanali
Neural Tangent Kernel integration + typo fix (mathLab#505)
0152d8c 
* NTK weighting + typo fixing
* black code formatter + .rst docs

---------

Co-authored-by: Dario Coscia <dariocos99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia requested changes

@ndem0 ndem0 ndem0 approved these changes

Assignees

@AleDinve AleDinve

Labels

pr-to-fix Label for PR that needs modification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AleDinve @dario-coscia @ndem0