Fix overlapping WFC pattern lookup and set_pattern bugs#15
Open
AliasFactory wants to merge 2 commits into
Open
Fix overlapping WFC pattern lookup and set_pattern bugs#15AliasFactory wants to merge 2 commits into
AliasFactory wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_pattern_id() dereferences the find iterator (*pattern_id) which returns the pattern content rather than its index in the vector. Fixed by using std::distance() to return the actual index.
set_pattern() passes std::optional directly to the private set_pattern(unsigned, unsigned, unsigned) overload instead of extracting the value first. Fixed by using .has_value() and .value().