Skip to content

Conversation

@llelf
Copy link
Contributor

@llelf llelf commented Apr 7, 2020

No description provided.

@affeldt-aist affeldt-aist self-assigned this Apr 8, 2020
@affeldt-aist affeldt-aist self-requested a review April 8, 2020 13:43
@ybertot ybertot requested review from ybertot and removed request for affeldt-aist April 8, 2020 13:44
@affeldt-aist affeldt-aist self-requested a review April 8, 2020 13:44
@affeldt-aist affeldt-aist added this to the 1.11.0 milestone Apr 8, 2020
@affeldt-aist
Copy link
Member

affeldt-aist commented Apr 8, 2020

For me, this PR can be merged as it is. (Thanks @llelf .)

(* [tuple E | i < n] == the n.-tuple with general term E (i : 'I_n is bound *)
(* in E). *)
(* tcast Emn t == the m-tuple t cast as an n-tuple using Emn : m = n. *)
(* tcast Emn t == the m.-tuple t cast as an n-tuple using Emn : m = n. *)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this modification. I don't see why adding a period here will help. Can you elaborate the need for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency. foo.-tuple (as a notation for tuple_of) is used everywhere in this file's header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be even the m.-tuple t cast as an n.-tuple then.
@ybertot apply or remove?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llelf You convinced me, and you are right about the second correction on the same line: --> "n.tuple"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I propose to fix L.16: (size s)-tuple -> (size s).-tuple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed both

llelf and others added 2 commits April 9, 2020 10:48
the->this

Co-Authored-By: Yves Bertot <yves.bertot@inria.fr>
@affeldt-aist affeldt-aist merged commit ad82c5f into math-comp:master Apr 9, 2020
@ybertot
Copy link
Member

ybertot commented Apr 9, 2020

Thanks a lot @llelf, it was great working with you on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants