-
Notifications
You must be signed in to change notification settings - Fork 125
Documentation typos #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation typos #474
Conversation
|
For me, this PR can be merged as it is. (Thanks @llelf .) |
mathcomp/ssreflect/tuple.v
Outdated
| (* [tuple E | i < n] == the n.-tuple with general term E (i : 'I_n is bound *) | ||
| (* in E). *) | ||
| (* tcast Emn t == the m-tuple t cast as an n-tuple using Emn : m = n. *) | ||
| (* tcast Emn t == the m.-tuple t cast as an n-tuple using Emn : m = n. *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this modification. I don't see why adding a period here will help. Can you elaborate the need for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency. foo.-tuple (as a notation for tuple_of) is used everywhere in this file's header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be even the m.-tuple t cast as an n.-tuple then.
@ybertot apply or remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llelf You convinced me, and you are right about the second correction on the same line: --> "n.tuple"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I propose to fix L.16: (size s)-tuple -> (size s).-tuple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed both
the->this Co-Authored-By: Yves Bertot <yves.bertot@inria.fr>
|
Thanks a lot @llelf, it was great working with you on this pull request. |
No description provided.