Merged
Conversation
zstone1
added
enhancement ✨
zstone1
force-pushed
the
smallest_filter
branch
from
1ffcedd to
5dfdd52
Compare
CohenCyril
reviewed
May 2, 2023
Member
CohenCyril
left a comment
CohenCyril
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The results are definitely useful. I have a few questions & comments though.
theories/topology.v
Outdated
| Qed. | ||
|
|
||
| Lemma smallest_filter_finI {T : choiceType} (D : set T) f : | ||
| D!=set0 -> filter_from (finI_from D f) id = smallest (@Filter T) (f @` D). |
Member
There was a problem hiding this comment.
Suggested change
| D!=set0 -> filter_from (finI_from D f) id = smallest (@Filter T) (f @` D). | |
| D !=set0 -> filter_from (finI_from D f) id = smallest (@Filter T) (f @` D). |
Also.
Could this be decomposed into:
filter_from D f = smallest superset_closed (f @D)`finI_from D f = smallest finI_closed (f @D)`smallest Filter X = setT|smallest superset_closed (smallest finI_closed X)
? (and maybe other variations withsetTor with nonemptyness ofX)
Contributor
Author
There was a problem hiding this comment.
Probably yes. I just proved the relationship I needed for my Urysohn's Lemma stuff. But these other variants are likely helpful elsewhere (E.G. with the sup topology). I'd rather add them in a separate PR, though.
Contributor
Author
|
Thanks for the review. Turns out putting a |
CohenCyril
approved these changes
Jun 27, 2023
CohenCyril
reviewed
Jun 27, 2023
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Jun 28, 2023
* various forms of smallest filters Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
proux01
pushed a commit
to affeldt-aist/analysis
that referenced
this pull request
Jul 8, 2023
* various forms of smallest filters Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
proux01
pushed a commit
that referenced
this pull request
Jul 8, 2023
* various forms of smallest filters Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
proux01
removed
the
TODO: MC2 port
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Sep 7, 2023
* various forms of smallest filters Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Splitting up the boring part of #900, this just shows that the following are all equivalent
Smallest filter Ffilter_from (\bigcup_n (smallest_filter_stage F n))(E.G. set of all pairwise intersections)filter_from (finI_from F)It also adds a notion of
set_nbhs A, which is the filter from all open sets containingA.I also added a gitignore for the
toolsrepo. Is this correct? If not, how else am I supposed to use the changelog generator?Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.