Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip another failing Phonopy test in Windows after NumPy bumped to 2 in CI #4224

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Skip another failing Phonopy test in Windows after NumPy bumped to 2 in CI #4224

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
286be51
skip another test
DanielYang59 Dec 12, 2024
51b822f
fix import
DanielYang59 Dec 12, 2024
77c602b
update reason
DanielYang59 Dec 12, 2024
b891244
what? looks like the latest monty doesn't pack reverse readline fix?
DanielYang59 Dec 12, 2024
3af8ad0
Revert "what? looks like the latest monty doesn't pack reverse readli…
DanielYang59 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
what? looks like the latest monty doesn't pack reverse readline fix?
  • Loading branch information
@DanielYang59
DanielYang59 committed Dec 12, 2024
commit b8912442b458ac6b409eaf0ae2ce423505a87218
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ jobs:
WHEEL_FILE=$(ls dist/pymatgen*.whl)
uv pip install $WHEEL_FILE[${{matrix.config.extras}}] --resolution=${{matrix.config.resolution}}

# TODO: test monty fix for reverse readline
uv pip install git+https://github.com/materialsvirtuallab/monty.git@master

- name: Install optional Ubuntu dependencies
if: matrix.config.os == 'ubuntu-latest'
run: |
Expand Down
Loading