Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VASP/ABINIT link in main README.md #4201

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Fix VASP/ABINIT link in main README.md #4201

merged 8 commits into from
Dec 11, 2024

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Nov 28, 2024 •
edited
Loading

Summary

  • Fix VASP/ABINIT hyperlink in main README.md

Can someone help me double check to make sure this is not my network issue?

# VASP
- https://cms.mpi.univie.ac.at/vasp
+ https://www.vasp.at/

# ABINIT
- https://abinit.org
+ https://abinit.github.io/abinit_web/

DanielYang59
DanielYang59 commented Nov 28, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@DanielYang59

This comment was marked as off-topic.

Sign in to view
@DanielYang59 DanielYang59 mentioned this pull request Nov 28, 2024
Open
@DanielYang59 DanielYang59 force-pushed the fix-vasp-abinit-link-readme branch from ab93741 to 039e352 Compare November 29, 2024 02:59
@DanielYang59 DanielYang59 changed the title Fix VASP/ABINIT hyperlink in main README.md Fix VASP/ABINIT link in main README.md Nov 29, 2024
@DanielYang59 DanielYang59 force-pushed the fix-vasp-abinit-link-readme branch from 0306c0f to 4de488a Compare November 30, 2024 13:11
@DanielYang59
Copy link
Contributor Author

I would put the markdown link checker on holder as it seems too fragile right now

@DanielYang59 DanielYang59 marked this pull request as ready for review November 30, 2024 13:15
@shyuep shyuep merged commit 461b56c into materialsproject:master Dec 11, 2024
1 of 2 checks passed
@DanielYang59 DanielYang59 deleted the fix-vasp-abinit-link-readme branch December 11, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielYang59 @shyuep