-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the documentation of the Lobsterenv module #3079
Merged
janosh
merged 25 commits into
materialsproject:master
from
JaGeo:lobsterenv_improvements
Jun 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fcf701f
Improve doc lobsterenv
JaGeo d304791
improve extremumg
JaGeo 12b4a24
fix mypy and extremum
JaGeo 45c757a
mypy
JaGeo bb80938
Fix documentation issues
JaGeo 8a0f83c
Implement named tuple
JaGeo d64182d
Fix line lengths
JaGeo 5a54305
add type hints to LobsterNeighbors.__init__
janosh e82c7cb
remove optional Structure
JaGeo d161ec3
Update pymatgen/io/lobster/lobsterenv.py
JaGeo 0bbbc99
remove optional Structure
JaGeo b250628
Merge branch 'lobsterenv_improvements' of github.com:JaGeo/pymatgen i…
JaGeo 49f8d4b
anion_types property
JaGeo c704184
Update pymatgen/io/lobster/lobsterenv.py
JaGeo d3af770
fix get_anion_types
JaGeo 03ea67a
fix get_anion_types
JaGeo a9c368b
pre-commit auto-fixes
pre-commit-ci[bot] 9f506f5
Add a test
JaGeo 1b6c930
Merge branch 'lobsterenv_improvements' of github.com:JaGeo/pymatgen i…
JaGeo e1c08fb
Fix test
JaGeo f4cd4d0
pre-commit auto-fixes
pre-commit-ci[bot] b175f54
Fix test
JaGeo 8ed8870
Fix test
JaGeo 6bab069
pre-commit auto-fixes
pre-commit-ci[bot] ec84331
remove mypy ignore, refactor tests
janosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix documentation issues
- Loading branch information
commit bb80938cd53cfef2605aa2490a7400ce9c3cf446
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return value of the function also has an "atoms" entry but I don't see that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct. I somehow merged labels and atoms in the description.