Skip to content

Commit

Permalink
Remove continue on error in Github workflow.
Browse files Browse the repository at this point in the history
This is giving misleading resutls.
  • Loading branch information
Shyue Ping Ong committed Jun 9, 2023
1 parent 56eca83 commit 60757b8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
split: 4

runs-on: ${{ matrix.os }}
continue-on-error: true

env:
PMG_MAPI_KEY: ${{ secrets.PMG_MAPI_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion pymatgen/io/ase.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def get_atoms(structure: SiteCollection, **kwargs) -> Atoms:
if hasattr(structure, "lattice"):
pbc = True
cell = structure.lattice.matrix
else: # Molecule without lattice
else: # Molecule without lattice
pbc = None
cell = None

Expand Down

0 comments on commit 60757b8

Please sign in to comment.