Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ensure_success apply to replace/detour/addition jobs #426

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

mcgalcode
Copy link
Contributor

Summary

Addresses #423 by keeping track of the results of running detour/replace/addition job and insisting they are all truth-y if ensure_success is True.

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running black on your new code. This will
    automatically reformat your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by flake8.
  • Docstrings have been added in theNumpy docstring format.
    Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply
cp pre-commit .git/hooks and a check will be run prior to allowing commits.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #426 (a04a236) into main (614ba43) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #426   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1509      1514    +5     
  Branches       412       413    +1     
=========================================
+ Hits          1509      1514    +5     
Files Changed Coverage Δ
src/jobflow/managers/local.py 100.00% <100.00%> (ø)

@utf
Copy link
Member

utf commented Sep 28, 2023

Thanks @mcgalcode

@utf utf added the fix Bug fix label Sep 28, 2023
@utf utf merged commit eddcfd3 into materialsproject:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants