Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning update #387

Merged
merged 14 commits into from
May 16, 2024
Merged

Versioning update #387

merged 14 commits into from
May 16, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented May 16, 2024

Address a few problems with the CI:

Modified ./pytest-docs.yml

Looks like the docs build has been failing for some time due to upstream package changes.

image

Modified the build pipeline to make sure tests pass

Automatic Versioning and release

With the new setup, you should just do a release on GitHub and the release workflow will automatically trigger.
I cannot test this without merging into main and affecting Pypi so I want to make sure this is reviewed.

@jmmshn jmmshn requested a review from janosh May 16, 2024 22:20
@jmmshn jmmshn requested review from mkhorton and janosh and removed request for janosh May 16, 2024 22:35
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 😄


[tool.versioningit.vcs]
default-tag = "0.0.1"
method = "git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses tags to set the version:
https://pypi.org/project/versioningit/0.3.3/

@jmmshn
Copy link
Collaborator Author

jmmshn commented May 16, 2024

OK, if I break things on PyPI I promise I'll fix ASAP!

@jmmshn jmmshn merged commit 4eb3ad7 into materialsproject:main May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants