-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit python to 3.11 #768
limit python to 3.11 #768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 76.64% 76.51% -0.13%
==========================================
Files 114 114
Lines 8506 8506
Branches 1275 1275
==========================================
- Hits 6519 6508 -11
- Misses 1600 1612 +12
+ Partials 387 386 -1 |
could you specify which ones? i'm not aware of this. unless there are some real blockers, i think now would be a good time to add official 3.12 support to
unfortunately, you can't release to pypi with urls in your package deps |
Hi @janosh , seems the issue is with spglib Steps to reproduce
|
|
Hi @janosh ,yes it supports but I just tried with Not sure what goes wrong. Maybe something specific to linux distros ? and for spglib developers to fix ? |
just tried on macOS and worked: . ~/.venv/py312/bin/activate
uv pip install -U spglib
python3.12 -c "import spglib; print(spglib.__version__)"
>>> 2.3.1 so looks like its linux specific |
For testing, you could switch on the workflows on pymatgen for Python 3.12. We now had this issue in different contexts: atomate2 but also LobsterPy |
Closing this as the new pymatgen version with 3.12 support is released now. |
Summary
Currently, on python 3.12, atomate2 installation fails due to some of the dependencies of pymatgen not supporting 3.12 yet.
It seems better fix for now to strictly limit the python version in atomate2.
Open question
There is still issue with ase with pip install. Would It be okay to strictly revert to
pip install git+https://gitlab.com/ase/ase.git
?Currently even with strict install , using forcefields based workflows is not possible without installing ase main branch.