-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons Reference #225
Comments
Good suggestion, we'll see what other contributors thinks |
PRs are very welcome. I think we should replace this long list with a simple link, as you correctly mention the outdated list in our docs. |
I'm often in the docs while developing with materialize. Isn't providing both is better than a page with a single link ? |
Generally that would mean we have to actively maintain the list. |
I want to contribute, please let me know what should be done here? Should I make changes to the list or just provide a link to the icon page? |
Hi @MadhaviMandalia, Thank you very much for asking.
That should be the right solution. PRs are very welcome. |
What is the approach you here? Where should I include the link on the icon page? |
You can safely remove the current list and add a text with the relevant link at the same place. It doesn't have to be perfect. You will get some feedback like change suggestions during the PR review phase. When everything is fine we will merge and deploy the changes. |
This looks good so far. I would change this:
To something like that:
Feel free to improve or use a different wording. |
Might be worth pointing to MDIDX over the official repo as it's far more supported. |
Ok I will include this one. |
I think it's still too discret.. The list should be removed.. It does not include all the icons and may induce the user to think that all the available icons are there and hard to seek without tags, or related words. |
You don't need to download, they are already included within materialize. |
It's a reference if you want to download them manually. Materialize does not include these icons. We just reference the Google Fonts there: https://materializecss.github.io/materialize/getting-started.html
That's what she currently does. |
So, should I include change the reference link or everything is fine? |
See my previous comments with the suggested changes. |
Hello @DanielRuf, Thanks.
|
I can not yet see any relevant PR at https://github.com/materializecss/materialize/pulls What I remember and what your PR should contain:
No extra changes needed regarding the quoted comment (as this was a clarification that materializecss does not include / ship the icon fonts). Does this answer your question @MadhaviMandalia? |
I have opened a PR in this repo please that check it out and let me know is there any change required Earlier by mistake I've opened a PR in Dogfalo/materialize 😃 Regards. |
Awesome, will take a look later today. |
Looks good, thanks for contributing! |
Hello @wuda-io & @DanielRuf , |
* fix: add link to searchable list materializecss#225 * Update pug/page-contents/icons_content.html Co-authored-by: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
As a recomendation, I think it would be nice to include in the Icons page, a link redirecting to the google fonts site in order to make the search for Icons easier via tags, something that it's not supported via Control + F in the icons page. And you may have realized that not all the Icons are present in that page.
Here is the link: https://fonts.google.com/icons?selected=Material+Icons
The text was updated successfully, but these errors were encountered: