Enhanced remote data #745
Closed
Enhanced remote data #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont have access to the sandbox link. Can you check it? |
|
Can you check the sandbox link again? |
ckchiu2
force-pushed
the
enhance-remote-data-code-sandbox
branch
from
e151dff to
89b6315
Compare
|
@Domino987 can you please check again? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required. |
|
Is this working now? I cannot get it working in my local environment. Still cannot use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#457
#703 -
props.pageandprops.totalCountis still not usedDescription
See #654, this is a rework of that branch because that branch is messed up when merging.
This time I add a sandbox preview to the changes.
And because I used codesandbox for development, I can now update package-lock.json. Hail codesandbox lol
Note that #703 is still not fixed. I decided to use them for the remote data only because local paging may mess up sorting (see #662, #670)
Related PRs
#654 This is a rework of that PR because that branch is messed up
Impacted Areas in Application
material-table.js (additional logic to handle another type of remote data)
index.d.ts (added isRemoteData type)
demos
package.json (added @reduxjs/toolkit as devDependencies for demo purpose)