Skip to content

Corrected initial order #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Diiegoav
Copy link
Contributor

Related Issue

#585 Multiple Sorting

Description

  • Corrected initial order.
  • Corrected sorting enabling.
  • Added previousDefaultOrder.

Works on normal, tree and group table, for group table groups child data only supports single sort.

Related PRs

List related PRs against other branches:

branch PR
other_pr_master link

Impacted Areas in Application

List general components of the application that this PR will affect:

* src/material-table.js
* src/utils/data-manager.js
* src/components/MTableHeader/index.js

Additional Notes

Please review the pr, let me know your thoughts, and if there is any feedback let me know to update the pr, I think this multicolumn sort could be a great contribution for all the community that uses material table :)

Corrected initial order.
Corrected sorting enabling.
Added previousDefaultOrder
@Domino987
Copy link
Contributor

Can you check with the newest changes and so it compiles?

@Diiegoav
Copy link
Contributor Author

Diiegoav commented Sep 26, 2022

Can you check with the newest changes and so it compiles?

I think there are issues also with dnd.

@Domino987 Domino987 merged commit 61a70b6 into material-table-core:experimental Sep 26, 2022
@Diiegoav Diiegoav deleted the feature/multi-column-sort-updates branch September 26, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants