fix: correct icon for Quarto#3531
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
|
Thanks for the PR. We know that we sometimes not fully align with the original "correct" logo. This is on purpose. VS Code renders all SVG with a 16x16 grid system - 16x16 pixels. When we follow that exact grid and fill out each pixel individually, we benefit from the rendering much more. Here's a comparison how the rendering looks like on 16x16 pixels The existing icon of this theme: https://material-extensions.github.io/svg-pixel-preview/ As you can see the first one has a very clear contrast between the edges and the background. The second one doesn't follow our grid with the cross edges and that's why it will suffer in the rendering. As you can see in our pixel perfect checker, the pixels are not filled out, we have half of the pixels filled out and another half not. This leads to less contrast in the edges:
I can understand your initial concern that we adjusted the original logo, but we only wanted to improve it's visibility as a small icon in the file explorer - we do this for all our icons if possible. And if you ask me, by looking at the file icon, it doesn't look that different from the original logo: The color change is something we can update for sure, that's not a problem at all. If the quarto community feels better with the updated logo to be more near to the original, we can also update it, but then the rendering will be worse. That's what you need to decide. |
|
Ah thanks for that added context! I am just a user of Quarto and pointed out some differences in the Quarto logo that I had noticed, which lead me to open this PR. So I'm not affiliated with the company that makes and publishes Quarto. I understand the limitations and think just adjusting the color would be a good alternative. I'll leave others to comment regarding the shape and such (@mcanouil and others on Quarto team). |
6ec135b to
fabed46
Compare
|
I can't speak for the Quarto Team, but I'll let them know. |




Description
Updated Quarto icon to correct fill color and shape. This fix updates the logo to the company's desired logo.
Prior addition: #3151
Motivating discussion in Quarto repository: https://github.com/orgs/quarto-dev/discussions/14672
Used the Color Converter to select
#64B5F6from#74AADBnpm run buildandnpm testpass locally@mcanouil to see if this looks ok from Quarto side.
Contribution Guidelines