Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): removed unnecessary setTimeout method #6224

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(list): removed unnecessary setTimeout method #6224

wants to merge 4 commits into from

Conversation

akaSourav
Copy link

@akaSourav akaSourav commented Jul 15, 2020

You are using the setTimeout method to wait and check that next focused element is inside the list or not.
But for focusout event FocusEvent.relatedTarget is the EventTarget which is receiving focus. So you can use FocusEvent.relatedTarget instead of the setTimeout method to check the focus is inside the list.

For focusout event, the relatedTarget is the EventTarget which receive the next focus. So you can use relatedTarget to check the list is in the focus or not.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@akaSourav akaSourav changed the title Removed unnecessary setTimeout method fix(list): removed unnecessary setTimeout method Jul 15, 2020
@akaSourav
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants