-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layout-grid): "base" span class specificity #6049
base: master
Are you sure you want to change the base?
fix(layout-grid): "base" span class specificity #6049
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hey Sampson, thanks for your PR! There are more changes in here than just layout-grid fixes (comment changes, decimal changes, etc). Let's revert those and keep this scoped to just the layout-grid fixes. Let me know if you have any questions! |
@patrickrodee without those "changes", the system doesn't pass tests because they violate the linting rules any changes that aren't directly from the grid updates are from running the I reverted and force pushed up just the grid updates |
1e160ba
to
6d3b60e
Compare
6d3b60e
to
d9eef4f
Compare
@SampsonCrowley has this effort been abandoned? It seems like the only fix to enable grid spacing/offsets... |
@chasingduende it wasn't responded to last time I jumped through the hoops to get things merged in, even though it was definitely something that was needed and all tests were passing. So yeah I haven't looked at it again. Feel free to steal it and claim the credit though |
"base" span classes should not be more specific than device-specific spans.
fixes #2228
also added
span-0
classes to implement #2270