Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout-grid): "base" span class specificity #6049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SampsonCrowley
Copy link

@SampsonCrowley SampsonCrowley commented Jun 9, 2020

"base" span classes should not be more specific than device-specific spans.
fixes #2228

also added span-0 classes to implement #2270

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SampsonCrowley
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 9, 2020
@patrickrodee patrickrodee self-assigned this Jun 11, 2020
@patrickrodee
Copy link
Contributor

Hey Sampson, thanks for your PR! There are more changes in here than just layout-grid fixes (comment changes, decimal changes, etc). Let's revert those and keep this scoped to just the layout-grid fixes.

Let me know if you have any questions!

@SampsonCrowley
Copy link
Author

SampsonCrowley commented Jun 15, 2020

@patrickrodee without those "changes", the system doesn't pass tests because they violate the linting rules

any changes that aren't directly from the grid updates are from running the fix script

I reverted and force pushed up just the grid updates

@SampsonCrowley SampsonCrowley force-pushed the fix-span-specificity branch 2 times, most recently from 1e160ba to 6d3b60e Compare June 15, 2020 20:10
@chasingduende
Copy link

chasingduende commented Apr 6, 2021

@SampsonCrowley has this effort been abandoned? It seems like the only fix to enable grid spacing/offsets...

@SampsonCrowley
Copy link
Author

@chasingduende it wasn't responded to last time I jumped through the hoops to get things merged in, even though it was definitely something that was needed and all tests were passing.

So yeah I haven't looked at it again. Feel free to steal it and claim the credit though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid cell styles for tablet don't take precedence over default
4 participants