feat(fab): Add support for increased touch target to mini FAB. #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 722 screenshot tests passed for commit 245f9f7 vs. |
abhiomkar
reviewed
Nov 6, 2019
packages/mdc-fab/_mixins.scss
Outdated
| @@ -305,6 +312,17 @@ $mdc-fab-icon-enter-duration_: 180ms; | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-fab--touch_($query: mdc-feature-all()) { | |||
| @include mdc-touch-target-component( | |||
There was a problem hiding this comment.
Not in the scope of this PR but would it make sense to rename mdc-touch-target-component() to mdc-touch-target-margin()? I think this mixin is only applying margin to increase its touch size.
WDYT?
There was a problem hiding this comment.
Makes sense! I'll do this in a follow-up CL/PR.
|
All 722 screenshot tests passed for commit 3d99131 vs. |
|
All 722 screenshot tests passed for commit 232c412 vs. |
abhiomkar
reviewed
Nov 6, 2019
| @import "@material/rtl/mixins"; | ||
| @import "@material/theme/functions"; | ||
| @import "@material/theme/mixins"; | ||
| @import "@material/touch-target/mixins"; |
There was a problem hiding this comment.
FAB's package.json missing dependency for touch target which might be causing failures in canary release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.