Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(chips): ts conversion #4332

Merged
merged 15 commits into from
Feb 7, 2019
Merged

feat(chips): ts conversion #4332

merged 15 commits into from
Feb 7, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Feb 1, 2019

related #4225

@codecov-io
Copy link

codecov-io commented Feb 1, 2019 •
edited
Loading

Codecov Report

Merging #4332 into feat/typescript will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4332      +/-   ##
===================================================
+ Coverage            98.53%   98.53%   +<.01%     
===================================================
  Files                   93       93              
  Lines                 5862     5885      +23     
  Branches               788      793       +5     
===================================================
+ Hits                  5776     5799      +23     
  Misses                  85       85              
  Partials                 1        1
Impacted Files Coverage Δ
packages/mdc-menu/index.ts 100% <ø> (ø) ⬆️
packages/mdc-chips/chip-set/index.ts 98.33% <100%> (ø)
packages/mdc-chips/chip/foundation.ts 100% <100%> (ø)
packages/mdc-chips/chip/index.ts 98.68% <100%> (ø)
packages/mdc-chips/chip-set/foundation.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3279cc9...3a79acb. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit e988241 vs. feat/typescript! 💯🎉

@kfranqueiro kfranqueiro mentioned this pull request Feb 1, 2019
Closed
45 tasks
@acdvorak acdvorak self-assigned this Feb 6, 2019
@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 61a214b vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 89c454a vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit e3a15ae vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit ce145c4 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 15b004f vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 17ee992 vs. feat/typescript! 💯🎉

acdvorak
acdvorak approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 3a79acb vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 1c7335b into feat/typescript Feb 7, 2019
@acdvorak acdvorak deleted the feat/chips-ts branch February 7, 2019 01:53
acdvorak added a commit that referenced this pull request Feb 23, 2019
@acdvorak
chore: Fix regression in MDCChipFoundation.getDimensions()
69e87e5 
PR #4332 inadvertently broke short-circuit logic and evaluation order.

The change caused incorrect ripple size calculations on filter chips without leading icons, which was caught by internal screenshot tests.
@acdvorak acdvorak mentioned this pull request Feb 23, 2019
Merged
acdvorak added a commit that referenced this pull request Feb 23, 2019
@acdvorak
chore: Fix regression in MDCChipFoundation.getDimensions() (#4443)
6faaabe 
PR #4332 inadvertently broke short-circuit logic and evaluation order.

The change caused incorrect ripple size calculations on filter chips without leading icons, which was caught by internal screenshot tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acdvorak acdvorak acdvorak approved these changes

Assignees

@acdvorak acdvorak

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moog16 @codecov-io @mdc-web-bot @acdvorak @googlebot