This repository was archived by the owner on Jul 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 231
fix(chips): id shuold be required prop #649
Merged
moog16
merged 11 commits into
material-components:rc0.10.0
from
mgr34:fix/chips/require-id
Feb 8, 2019
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3cc6fa8
fix(chips): id shuold be required prop
mgr34 20f0860
fix(chips): @id is no longer optional
mgr34 491cb8b
fix(chips): id still optional
mgr34 1b123ae
Merge remote-tracking branch 'origin/rc0.10.0' into fix/chips/require-id
mgr34 87bb904
fix(chips): ChipSet will throw error if (choice || filter || input) a…
mgr34 4f47a91
merging rc0.10.0 into branch
mgr34 480bc74
fix(chips): isOk => doesNotThrow
matchew 4ae7355
Revert "fix(chips): isOk => doesNotThrow"
matchew 13c3c04
fix(chips): isOk => doesNotThrow
mgr34 ce02358
fix(chips): tests are now passing
mgr34 f04eb2d
Merge remote-tracking branch 'origin/rc0.10.0' into fix/chips/require-id
mgr34 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.