This repository was archived by the owner on Jan 14, 2025. It is now read-only.
test: capture screenshots with capture-chrome, and diff them with resemble #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-components-web-react into test/capture
moog16
reviewed
Mar 10, 2018
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "presets": [ | |||
| "es2015" | |||
There was a problem hiding this comment.
can we also add "react" here? We don't have any jsx files yet, so we can add it then.
There was a problem hiding this comment.
I think i want to wait, because this babelrc is actually affecting our babel translator for the mocha. So basically this is running on like capture-suite.js
There was a problem hiding this comment.
Ya, but I don't think it affects .js files that don't have JSX in it. It basically compiles the JSX -> JS. Although I'm testing the branch again right now and having issues, but don't think it is related to the .babelrc file.
moog16
reviewed
Mar 10, 2018
test/screenshot/screenshot.js
Outdated
| return Promise.all([capturePromise, readPromise]) | ||
| .then(function([newScreenshot, oldScreenshot]) { | ||
| return new Promise(function(resolve) { | ||
| const resolve2 = function(data) { |
moog16
approved these changes
Mar 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.